[Bug 1201662] Review Request: wiredtiger - WiredTiger data storage engine

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1201662



--- Comment #5 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> ---
(In reply to Marek Skalický from comment #3)
> (In reply to Jonathan Underwood from comment #1)
> > Output of rpmlint following a mock rebuild of the packages:
> > 
> > $ rpmlint *.rpm
> > wiredtiger.src: W: name-repeated-in-summary C WiredTiger
> 
> Upstream rpm template -
> https://github.com/wiredtiger/wiredtiger/blob/master/dist/package/wiredtiger.
> spec

Nonetheless, the name doesn't need to be repeated in the Summary. "A data
storage engine" would be sufficient, and silence the warning.


> > wiredtiger.src: W: invalid-url Source0:
> > https://github.com/wiredtiger/wiredtiger/releases/download/2.5.1/wiredtiger-
> > 2.5.1.tar.bz2 HTTP Error 403: Forbidden
> 
> This url is functional... try it.

It is now - but it wasn't earlier - must have been some sort of connectivity
issue. Anyway, confirmed, it is valid.



> > wiredtiger-devel.x86_64: W: only-non-binary-in-usr-lib
> > wiredtiger-devel.x86_64: W: no-documentation
> > wiredtiger-java.x86_64: W: no-documentation
> 
> devel and java subpackages requires -libs subpackage, which have the
> documentation. Its a normal usage of -devel, to ship .so and .pc files...
> 

The .so should have the executable bit set.

> > wiredtiger-java.x86_64: W: devel-file-in-non-devel-package
> > /usr/lib64/libwiredtiger_java.so
> 
> I thought that this library is not for ordinary use. It is used only by .jar
> files...
> 

OK, is this a plugin used only by wiredtiger? If so, it should be in a private
directory, rather than on the linker search path.


> > wiredtiger-python.x86_64: W: no-documentation
> > wiredtiger-python.x86_64: E: non-executable-script
> > /usr/lib/python2.7/site-packages/wiredtiger/packing.py 0644L /usr/bin/env
> > wiredtiger-python.x86_64: E: non-standard-executable-perm
> > /usr/lib/python2.7/site-packages/wiredtiger/_wiredtiger.so 0775L
> > wiredtiger-python.x86_64: E: non-executable-script
> > /usr/lib/python2.7/site-packages/wiredtiger/packing-test.py 0644L
> > /usr/bin/env
> > wiredtiger-python.x86_64: E: non-executable-script
> > /usr/lib/python2.7/site-packages/wiredtiger/fpacking.py 0644L /usr/bin/env
> > wiredtiger-python.x86_64: E: non-executable-script
> > /usr/lib/python2.7/site-packages/wiredtiger/intpacking.py 0644L /usr/bin/env
> > wiredtiger-python.x86_64: E: non-executable-script
> > /usr/lib/python2.7/site-packages/wiredtiger/intpack-test.py 0644L
> > /usr/bin/env
> > 7 packages and 0 specfiles checked; 6 errors, 10 warnings.
> 
> Why should python2.7 modules file have exec right? If I try "ls -l
> /usr/lib/python2.7/site-packages/", scripts there doesn't have exec right
> too...

You've misunderstood the rpmlint error message. What it's saying is that these
files have a shebang set at the top, and yet are non-executable. If the files
are not meant to be executable files, you also need to remove the shebang at
the top of the files. A recipe something like this would work (untested):

find %{buildroot}%{python_sitearch}/wiredtiger -name '*.py' \
    -exec sed -i '1{\@^#!/usr/bin/env python@d}' {} \;

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]