https://bugzilla.redhat.com/show_bug.cgi?id=1200389 --- Comment #14 from Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> --- (In reply to Petr Pisar from comment #13) > FIX: Removing badly licensed files at build time does not remove them from > source RPM package. Either repackage the source archive, or ask Fedora legal > for help. Correct. The source archive is now overriden. > Notice: Also the copied /usr/include/p11-kit-1/p11-kit/pkcs11.h still is > derivated work of the RSA-copyrighted work: > /* This file is a modified implementation of the PKCS #11 standard by > RSA Security Inc. It is mostly a drop-in replacement, with the > following change: This is not what the text above says. The header in p11-kit is a reimplementation of the PKCS #11 standard header. The license is the FSFUL. > > FIX: Require(pre) `shadow-utils because of useradd in %pre section. > %package softhsm > [...] > +Requires(pre): shadow-utils > FIX: The dependency should on the main package, not softhsm sub-package as > this where the %pre section belongs to. Thanks for the catch. Done. > > > standard path recognized by a linker. > > This is not a private library but rather a PKCS #11 module, and that is the > > standard path for them. I'd prefer if this package provides this library in > > case some program directly links to it. > > If some program directly links to it, then it must be in standard library > search path (/etc/ld.so.conf). Because it's not, it must not be provided. > > FIX: So either it's a public library, or it's a private library. See > <https://fedoraproject.org/wiki/Packaging: > AutoProvidesAndRequiresFiltering#Private_Libraries> for the second case, and > <https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Beware_of_Rpath> for the first case. Done (no longer provide it) New package: Spec URL: http://people.redhat.com/nmavrogi/fedora/caml-crush.spec SRPM URL: http://people.redhat.com/nmavrogi/fedora/caml-crush-1.0.4-4.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review