https://bugzilla.redhat.com/show_bug.cgi?id=1200885 gil cattaneo <puntogil@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #2 from gil cattaneo <puntogil@xxxxxxxxx> --- (In reply to Gerard Ryan from comment #1) > Approved. Please enable tests as detailed below before importing. Thanks for > packaging! :) > > > Issues: > ======= > [!]: %check is present and all tests pass. > Tests are currently disabled with a note about missing settings from > parent POM, which is not packaged. I've managed to get them to work by > adding the following to %prep, so please enable them before importing: > > %pom_xpath_inject "pom:dependency[pom:artifactId='testng']" > '<version>4.7</version>' Done > ^The problem is that there's no version set, so maven sees the version > as SYSTEM, and that fails a check for version 4.7+. Since we ignore > the version most of the time anyway, we can set it to anything from > 4.7 or later to get this to work (Rawhide has 6.8.21). Inserted 6.8.7 (use guava 18.0) > There are other settings in the parent POM for surefire plugin, but > they don't seem to matter too much, all tests passed for me in mock. Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9292637 Thanks! Spec URL: https://gil.fedorapeople.org/airline.spec SRPM URL: https://gil.fedorapeople.org/airline-0.7-1.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review