https://bugzilla.redhat.com/show_bug.cgi?id=1194545 Adam Williamson (Fedora) <adamw+fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adamw+fedora@happyassassin. | |net Flags| |fedora-review+ --- Comment #6 from Adam Williamson (Fedora) <adamw+fedora@xxxxxxxxxxxxxxxxx> --- Looks fine. I'm not sure what the Party Line is on whether we're supposed to make 'python-foo' the py3 version and have a 'python2-foo' these days, or vice versa, or have just 'python2-foo' and 'python3-foo' and have a virtual Provides: for 'python-foo' which we can switch over at will; but I don't think that needs to block the review. [adamw@adam SRPMS]$ rpmlint python-cached_property-1.0.0-2.fc23.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [adamw@adam SRPMS]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/python-cached_property-1.0.0-2.fc23.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [adamw@adam SRPMS]$ rpmlint python-cached_property-1.0.0-2.fc23.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [adamw@adam SRPMS]$ rpmlint ../SPECS/python-cached_property.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. All must-have items on the review checklist pass => APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review