[Bug 1199184] Review Request: DecodeIR - Infrared remote controls decoding library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1199184

Ville Skyttä <ville.skytta@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |ASSIGNED
                 CC|                            |ville.skytta@xxxxxx
             Blocks|                            |496968 (DebugInfo)



--- Comment #16 from Ville Skyttä <ville.skytta@xxxxxx> ---
(In reply to gil cattaneo from comment #4)
> ===== MUST items =====
> [x]: Useful -debuginfo package or justification otherwise.

Careful, reviewer. It is not useful, rpmlint would have told that had it been
run on -debuginfo:

$ rpmlint ./DecodeIR-debuginfo-2.45-2.fc23.x86_64.rpm 
DecodeIR-debuginfo.x86_64: E: debuginfo-without-sources

The fix seems to be a matter of something like this:

 %build
-make %{?_smp_mflags}
+CFLAGS="%{optflags}" make %{?_smp_mflags}
 %mvn_build

However this will at least on my system cause a build failure, debugedit barfs
with "canonicalization unexpectedly shrank by one character", so this needs to
be investigated more.

BTW setting the CFLAGS in %install appears to be superfluous, and it's done
kind of "wrong" there (after "make" as opposed to before will cause it to
override upstream CFLAGS which isn't desirable here, see Makefile).


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=496968
[Bug 496968] Tracking bug for packages with debuginfo problems
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]