Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adminutil - Utility library for Fedora Directory Server administration Alias: adminutil https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235293 dennis@xxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dennis@xxxxxxxx Flag| |fedora-review? ------- Additional Comments From dennis@xxxxxxxx 2007-05-17 23:10 EST ------- source files match upstream: 3f3aedc553e9f4eb9c0a1e9e6e047bf4 adminutil-1.1.1.tar.bz2 3f3aedc553e9f4eb9c0a1e9e6e047bf4 ../SOURCES/adminutil-1.1.1.tar.bz2 package meets naming and versioning guidelines. specfile is properly named, is cleanly written and uses macros consistently. dist tag is present. build root is correct. %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) license field matches the actual license. license is open source-compatible. LGPL License text included in package. latest version is being packaged. compiler flags are appropriate. %clean is present. package builds in mock ( devel x86_64). package installs properly debuginfo package looks complete. rpmlint says W: adminutil-devel no-documentation owns the directories it creates. doesn't own any directories it shouldn't. no duplicates in %files. file permissions are appropriate. no scriptlets present. code, not content. documentation is small, so no -docs subpackage is necessary. %docs are not necessary for the proper functioning of the package. no libtool .la droppings. not a GUI app. Needs work: final provides and requires are sane: all devel packages with .pc packages need to Requires: pkgconfig pkgconfig should not be BuildRequires it is provided by the devel packages that are BuildRequires and provide .pc files i filed bug# 240516 # cyrus-sasl-devel is required because mozldap uses it BuildRequires: cyrus-sasl-devel mozldap-devel should require it if this is the case. Fix these small issues and i will approve adminutil -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review