https://bugzilla.redhat.com/show_bug.cgi?id=1200389 --- Comment #11 from Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> --- (In reply to Petr Pisar from comment #10) > TODO: The caml-crush description reads `This software is a computer program' > which sound a little bit redundant. I would remove the phrase. Done. > FIX: License tag is wrong. Fixed in an alternative way. Use p11-kit's header to avoid dependency on RSA's license. Sent patch upstream as well. > FIX: Build-require `systemd' for %{_unitdir} macro in the spec file. Done. > TODO: Remove redundant configure arguments: --bindir, --libdir Done. > FIX: Require(pre) `shadow-utils because of useradd in %pre section. Done. > FIX: Add `exit 0' at the end of %pre section Done. > TODO: Run-require p11-kit by caml-cruh-softhsm pacakge for > %{_datadir}/p11-kit/modules directory. Done. > FIX: Remove executable bit from > /var/lib/pkcs11proxyd/.config/pkcs11/pkcs11.conf and > /var/lib/pkcs11proxyd/.config/pkcs11/modules/softhsm.module. Done. > FIX: Mark /etc/pkcs11proxyd/filter-softhsm.conf and > /etc/pkcs11proxyd/pkcs11proxyd-softhsm.conf as configuration file by > `%config(noreplace)' in the %files section. These are intentionally not configuration files. They are supposed to change on upgraded. For configuring a module one can use the caml-crush package (instead of caml-crash-softhsm). > $ rpm -q --provides -p ../RPMS/x86_64/caml-crush-1.0.4-3.fc23.x86_64.rpm | > sort -f | uniq -c > 1 caml-crush = 1.0.4-3.fc23 > 1 caml-crush(x86-64) = 1.0.4-3.fc23 > 1 config(caml-crush) = 1.0.4-3.fc23 > 1 libp11client.so()(64bit) > Fix: Do not provide `libp11client.so()(64bit)'. It's a private library in > non-standard path (/usr/lib64/pkcs11/libp11client.so). This is not a private library but rather a PKCS #11 module, and that is the standard path for them. I'd prefer if this package provides this library in case some program directly links to it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review