[Bug 1175952] Review Request: efl - Collection of Enlightenment libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1175952



--- Comment #13 from Richard Shaw <hobbes1069@xxxxxxxxx> ---
Ok, there's a problem with the cmake package in rawhide right now so I'm
re-running fedora-review with f22 instead. While it's running I have some
feedback:

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

This is due to the cmake problem in rawhide, ignore for now.


- Permissions on files are set properly.
  Note: See rpmlint output
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions


- Package contains BR: python2-devel or python3-devel

This package does not BR python at all. I haven't looked through the packaged
files but I have to assume that it's finding some python files?


- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find COPYING.BSD in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


Generic:
[!]: update-mime-database is invoked in %post and %postun if package stores
     mime configuration in /usr/share/mime/packages.
     Note: mimeinfo files in: efl
     See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo


[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/ethumb(ethumb),
     /usr/share/edje(edje-devel), /usr/lib64/ecore(ecore),
     /usr/lib64/evas/modules/engines(evas), /usr/lib64/efreet(efreet),
     /usr/include/ethumb-1(ethumb-devel),
     /usr/lib64/evas/modules/engines/wayland_shm(evas), /usr/include/eet-1
     (eet-devel), /usr/lib64/evas/modules/engines/fb(evas),
     /usr/share/evas(evas), /usr/lib64/evas/cserve2(evas), /usr/include/eio-1
     (eio-devel), /usr/include/ecore-1(ecore-devel), /usr/include/edje-1(edje-
     devel), /usr/include/eeze-1(eeze-devel), /usr/lib64/ethumb(ethumb),
     /usr/include/eina-1/eina(libeina-devel), /usr/lib64/emotion(emotion),
     /usr/include/eina-1(libeina-devel),
     /usr/lib64/evas/modules/engines/software_x11(evas),
     /usr/share/edje/include(edje-devel), /usr/include/efreet-1(efreet-devel),
     /usr/include/evas-1(evas-devel), /usr/lib64/edje(edje, emotion),
     /usr/lib64/evas/modules(evas), /usr/lib64/evas(evas),
     /usr/lib64/evas/modules/engines/gl_x11(evas), /usr/include/emotion-1
     (emotion-devel), /usr/share/emotion(emotion),
     /usr/lib64/edje/modules(emotion),
     /usr/lib64/edje/modules/emotion(emotion), /usr/lib64/edje/utils(edje)

Is this somehow causes by getting rid of all the sub-packages?


Rpmlint
-------
Checking: efl-1.13.1-5.fc23.x86_64.rpm
          efl-devel-1.13.1-5.fc23.x86_64.rpm
          efl-1.13.1-5.fc23.src.rpm
efl.x86_64: W: shared-lib-calls-exit /usr/lib64/libecore_x.so.1.13.1
exit@GLIBC_2.2.5
efl.x86_64: E: setuid-binary /usr/bin/eeze_scanner root 04555L

I'm assuming eeze needs setuid?


efl.x86_64: E: non-standard-executable-perm /usr/bin/eeze_scanner 04555L
efl.x86_64: E: non-standard-executable-perm /usr/bin/eeze_scanner 04555L

Needed?

efl-devel.x86_64: E: library-without-ldconfig-postin
/usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.py
efl-devel.x86_64: E: library-without-ldconfig-postun
/usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.py
efl-devel.x86_64: E: library-without-ldconfig-postin
/usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyc
efl-devel.x86_64: E: library-without-ldconfig-postun
/usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyc
efl-devel.x86_64: E: library-without-ldconfig-postin
/usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyo
efl-devel.x86_64: E: library-without-ldconfig-postun
/usr/share/gdb/auto-load/usr/lib64/libeo.so.1.13.1-gdb.pyo

I'm assuming this is what's causing the python errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]