https://bugzilla.redhat.com/show_bug.cgi?id=1203610 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 are usable. Ok Source archive is original (SHA-256: 4cf0ecfaefd425ac6f171fff5430e770efc3ea161475ee8856ccd23a974502dc). Ok. Summary verified from lib/GStreamer1.pm. Ok. TODO: I think better summary would be `Perl bindings for GStreamer 1.0' without the explanation what GStreamer is. Description verified from lib/GStreamer1.pm. Ok. TODO: There is no word about Perl. The description would be more suitable for gstreamer1 package than perl-GStreamer1. Please make it more specific. License verified from Makefile.PL, lib/GStreamer1.pm, lib/GStreamer1/Caps/Simple.pm, t/001_load.t, and t/010_caps_simple.t. Ok. TODO: I would recommend to package examples directory instead of dist.ini file as %doc. No XS code, noarch BuildArch is Ok. TODO: Add `>= 0.009' constrain to `perl(Glib::Object::Introspection)' build-require (Makefile.PL:30). TODO: Build-require `perl' (perl-GStreamer1.spec:47). TODO: Build-require `perl(strict)' (Makefile.PL:3). TODO: Build-require `perl(warnings)' (Makefile.PL:4). TODO: Add `GstController-1.0.typelib' to `For Gst-1.0.typelib and GstApp-1.0.typelib' comment in the spec file (lib/GStreamer1.pm:39). It's very said that gstreamer1 does not have virtual provides for the gstreamer registry entries. TODO: You can use plain `perl' command instead of `%{__perl}' macro. TODO: You can use DESTDIR argument instead of PERL_INSTALL_ROOT argument in the %install section. Build-requires are Ok. All tests pass. Ok. $ rpmlint perl-GStreamer1.spec ../SRPMS/perl-GStreamer1-0.003-2.fc23.src.rpm ../RPMS/noarch/perl-GStreamer1-0.003-2.fc23.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-GStreamer1-0.003-2.fc23.noarch.rpm drwxr-xr-x 2 root root 0 Mar 19 14:27 /usr/share/doc/perl-GStreamer1 -rw-r--r-- 1 root root 265 Nov 27 17:41 /usr/share/doc/perl-GStreamer1/CHANGELOG -rw-r--r-- 1 root root 552 Nov 27 17:41 /usr/share/doc/perl-GStreamer1/dist.ini -rw-r--r-- 1 root root 2986 Mar 19 14:27 /usr/share/man/man3/GStreamer1.3pm.gz drwxr-xr-x 2 root root 0 Mar 19 14:27 /usr/share/perl5/vendor_perl/GStreamer1 -rw-r--r-- 1 root root 6324 Nov 27 17:41 /usr/share/perl5/vendor_perl/GStreamer1.pm drwxr-xr-x 2 root root 0 Mar 19 14:27 /usr/share/perl5/vendor_perl/GStreamer1/Caps -rw-r--r-- 1 root root 1948 Nov 27 17:41 /usr/share/perl5/vendor_perl/GStreamer1/Caps/Simple.pm File layout and permissions is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-GStreamer1-0.003-2.fc23.noarch.rpm | sort -f | uniq -c 1 gstreamer1 1 gstreamer1-plugins-base 1 perl >= 1:5.12 1 perl(:MODULE_COMPAT_5.20.2) 1 perl(Glib::Object::Introspection) 1 perl(GStreamer1::Caps::Simple) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Add `>= 0.009' constrain to `perl(Glib::Object::Introspection)' run-require (Makefile.PL:30). $ rpm -q --provides -p ../RPMS/noarch/perl-GStreamer1-0.003-2.fc23.noarch.rpm | sort -f | uniq -c 1 perl(GStreamer1) = 0.003 1 perl(GStreamer1::Caps::Simple) = 0.003 1 perl-GStreamer1 = 0.003-2.fc23 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-GStreamer1-0.003-2.fc23.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9273521). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please consider fixing `TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review