[Bug 893399] Review Request: asekey - ASEKey USB token driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=893399



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
(In reply to Nikos Mavrogiannopoulos from comment #2)
> Why you need Fedora >= 17? Anything under 19 is unsupported. Is it some epel
> version you target?
>
There is nothing about Fedora 17 in the spec file. The pcsc-lite version is
specified because this package is not compatible with earlier pcsc-lite
versions. If you ask why it's there, then it's because (1) I submitted the
package review many years ago when Fedora 17 was relevant and because (2) it
states what's true. If somebody decides to build the package in different
distribution (e.g. EPEL), the he will be warned ahead.

> I don't have the hardware to check. I simply check whether this module is
> loaded by pcsc-lite.
>
I have the hardware. I don't you use on Fedora, but it worked. I checked it now
in Fedora 21. It still works.

> Shouldn't the name of this spec be pcsc-lite-asekey similar to
> pcsc-lite-ccid? It's a driver of pcsc-lite after all.
>
Guidelines recommends to stick to upstream name. Also it's driver for any PCSC
service talking IFD interface.

> You should mention in spec the license break-down... In that case, the
> LGPL-licensed file is only 92_pcscd_asekey.rules.

Yes. I will. I will update the package, as guidelines changed since the time I
submitted this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]