Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sergueis-destiny - Serguei's Destiny, an AGI adventure game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240195 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2007-05-17 14:50 EST ------- MUST: ===== * rpmlint output is empty * Package and spec file named appropriately * Packaged according to packaging guidelines 0 License NOT ok! * spec file is legible and in Am. English. * Source matches upstream (as explained in the comment) * Compiles and builds on devel x86_64 * BR: ok * No locales * No shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions * %clean & macro usage OK * Contains code and permissable content * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed * .desktop file as required and properly installed Must FIX ======== * The readme says this game is freeware, not public domain, freeware is an ambigous term, please contact upstream for clarification, this is a blocker! * Drop the bogus " sergueis-destiny" argument to %setup * sergeui.txt is not in UTF-8 , this fixes it: iconv -f IBM850 -t UTF8 sergeui.txt > tmp mv tmp sergeui.txt Should fix ========== * Change the last line of dgae-wrapper.sh from 'nagi' to 'exec nagi "$@"' the exec removes a useless bash instance from memory (since the script does nothing after the nagi line, bash can just be replaced with nagi instead of nagi running under bash. the "$@" passed any cmdline args given to the script to nagi (although it seems that nagi takes no cmdline args??). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review