https://bugzilla.redhat.com/show_bug.cgi?id=1202379 --- Comment #2 from Kalev Lember <kalevlember@xxxxxxxxx> --- Fedora review fwupd-0.1.0-1.fc21.src.rpm 2015-03-16 + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. ! The package meets the Packaging Guidelines Some questions below about systemd macro use. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license ! The license text (COPYING) is included in %license Can you use %license COPYING instead of %doc COPYING please? + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm 57e840121eafe4eb5510b9e8de274423 fwupd-0.1.0.tar.xz 57e840121eafe4eb5510b9e8de274423 Download/fwupd-0.1.0.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane + locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 According to https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd , should also have: Requires(post): systemd Requires(preun): systemd Requires(postun): systemd ... to make sure rpm orders the transactions so that systemd gets installed before fwupd. Another question is if it should have %systemd_postun or %systemd_postun_with_restart in %post? I don't know the answer to that, but it probably depends on whether it is safe to restart the daemon during package upgrades? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review