Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nagi - An interpreter for AGI games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239812 ------- Additional Comments From musuruan@xxxxxxxxx 2007-05-17 08:22 EST ------- Instead of using %{__sed} you should use sed, for constistency with how you wrote make, rm, install, etc. I think you shouldn't use the original debian names for the patches, but rename them the fedora way (i.e. adding the version). You may optionally track the fact that these patches (and Source1) comes from Debian with some comment lines or a line in the changelog (that maybe useful for you and others to remember where these originated). There is no configure, so why adding this comment line? #./configure --prefix=/usr --mandir=%{_mandir} --libdir=%{_libdir} In the %install section: mkdir -p %{buildroot} is not needed. Just create the directory you need before installing something there. Therefore, before: install -D -m755 ../bin/nagi %{buildroot}/%{_bindir}/nagi add the following line (as you have done in the rest of this section): mkdir -p %{buildroot}/%{_bindir} -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review