https://bugzilla.redhat.com/show_bug.cgi?id=1202131 --- Comment #3 from Paulo Andrade <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- > - Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files directly in %_libdir. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > > Please try to do versioned library. > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Downstream_.so_name_versioning This is somewhat common pattern now, e.g. look at find /usr/lib64 -maxdepth 1 -name lib*-*.so -a -type f But I can rename (and add soname) it from libmozjs-31.so to libmozjs-31.so.1 and add a symlink in the devel package. > - If (and only if) the source package includes the text of the license(s) in > its own file, then that file, containing the text of the license(s) for the > package is included in %doc. > Note: Cannot find LICENSE in rpm(s) > See: > http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text > I'm not sure if it's false positive, but I think it's because no %license in > devel subpkg I think it is a false positive: $ rpm -ql mozjs31|grep LICENSE /usr/share/licenses/mozjs31/LICENSE I also updated the license line to match what licensecheck found. Those are mostly stragglers in the test subdir, or in bundled, but not built subtrees, like icu and ffi. The actual js sources should be all MPL2.0, but for safety, as build or test scripts have a different license, it was updated. > - delete INSTALL file from -devel subpkg, it's not needed Removed. As extra notes: o I built the package based on mozjs24, but added extra configure options, and build requires to ensure it uses system icu, system zlib, and system ffi. o Enabled %check. mozjs24 did not use it, 0ad bundled build builds with --disable-tests. It pass 95%+ of the tests, so for now it is mostly to check if it is not completely broken, i.e. if fails only 15+ test out of 1k ish tests. o It does not run smp make because it has some dependency missing. At first I preferred to just disable it, as the package actually builds quite fast. Update: Spec URL: https://pcpa.fedorapeople.org/mozjs31.spec SRPM URL: https://pcpa.fedorapeople.org/mozjs31-31.2.0-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review