[Bug 1202063] Review Request: Classified ads - Internet messaging done right

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1202063

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
_ → - in name

QMAKE_ARGS+="INCLUDEPATH+=${LOCALBASE}/include/miniupnpc/
LIBS+=-L${LOCALBASE}/lib"
Since you don't export those variables this has no effect. The paths look wrong
too — they are not multiarch at least. Maybe somebody who knows how to package
qmake-qt4-based stuff will chime in.

Remove %clean, BuildRoot, unless you'll be building this also for EPEL5.

Why fontconfig in Requires?

Most likely various things in Requires are unnecessary. Dependencies on
libraries are added automatically. Try removing all of them, building the
package, looking at autogenerated requires, and maybe adding something back.

No license file?

Since this seems to be a graphical application, you need an appdata file too.

Use %{version} in URL.
Use the URL you have for Source0, and use a link to a human-readable web-page
in URL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]