https://bugzilla.redhat.com/show_bug.cgi?id=1198040 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Suggestions: 1) we have a license macro now so you can use it as %doc NEWS README %license COPYING COPYINGv2 2) Above License: tag add following lines #Files from gtk-js-app are licensed under 3-clause BSD. #Other files are GPL 2.0 or later. 3) Package does not contain any libtool archives (.la) Note: gnome-characters : /usr/lib64/org.gnome.Characters/libgc.la See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries => Use in %install find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';' Otherwise looks good. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review