https://bugzilla.redhat.com/show_bug.cgi?id=1055712 Jan Chaloupka <jchaloup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lsm5@xxxxxxxxxx Flags| |needinfo?(lsm5@xxxxxxxxxx) --- Comment #13 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- Looking at Provides of devel subpackage, do we have to provide old docker-io-... as well? docker-devel and docker-pkg-devel should be sufficient for f22. The same for other subpackages: fish-completion provides docker-io-fish-completion. Or is this because of upgrade path from f21 to f22? In this case spec file is fine. Summary: - wmdocker is already renamed - wmdocker for f22 and higher no longer obsoletes docker - docker repository for master branch (f22 in this case) is dead.package so we can reuse the branch and create master (f23) for this docker - building docker from vendored source codes is fine as it needs update of github.com/coreos/libcontainer and 1.4.0 version is not back-compatible with 1.2.0 (see [1]) - license is correct (ASL 2.0) - provider, provider_tld, project, repo, import_path, commit macros presented - devel subpackage is missing some BuildRequires but as it is built from vendored source codes and there is a cyclic dependency on libcontainer, this is not an issue [1] Api check of libcontainer-1.2.0 and libcontainer-1.4.0 (incompatible changes): $ gofed apidiff libcontainer-1.2.0 libcontainer-1.4.0 -c Package: . -interface Container removed methods: Path -identifiers differ in type: error != Error -identifiers differ in type: error != Error -identifiers differ in type: error != Error -identifiers differ in type: error != Error -identifiers differ in type: error != Error -identifiers differ in type: error != Error -identifiers differ in type: error != Error -identifiers differ in type: error != Error -identifiers differ in type: error != Error Package: cgroups -ActiveCgroup type removed -struct CpuUsage: CurrentUsage field removed -struct CpuUsage: PercentUsage field removed Package: cgroups/fs -Paths func removed -Cleanup func removed -type differs: pointer != map -type differs: selector != map Package: cgroups/systemd -Paths func removed -Cleanup func removed -GetStats func removed -type differs: selector != map Package: mount -Mounts type removed -OfType func removed Package: namespaces -function CreateCommand: parameter count changed: 7 -> 6 -Selector differs in selector: syncpipe != os, at function: Init -Selector differs in expression: SyncPipe != File, at function: Init -function DefaultCreateCommand: parameter count changed: 7 -> 6 -function Exec: parameter count changed: 10 -> 9 -function InitializeNetworking: parameter count changed: 4 -> 3 -type differs: selector != map Package: netlink -function NetworkCreateVethPair: parameter count changed: 2 -> 3 Package: network -function CreateVethPair: parameter count changed: 2 -> 3 Package: user -GetUserGroupSupplementaryHome func removed -function ParsePasswd: parameter count changed: 0 -> 1 -function ParsePasswdFilter: parameter count changed: 1 -> 2 -function ParseGroupFilter: parameter count changed: 1 -> 2 -function ParseGroup: parameter count changed: 0 -> 1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review