Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: muParser - A fast math parser library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240287 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: muParser - |Review Request: muParser - |A fast math parser library |A fast math parser library CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-17 00:45 EST ------- A few issues I found: The compiler isn't called with the proper flags; I think it should suffice to call make like: make CXXFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags} Loads of errors like the following: warning: File listed twice: /usr/share/doc/muParser/html which are due to the same directories being included multipe times in %files: %{_docdir}/%{name} %{_docdir}/%{name}/html %doc %{_docdir}/%{name}/html/* It looks like you probably want to do the following at the end of %install instead of copying the files into the buildroot: mv docs/html . And then you can just have %doc html in %files which gets all of the html documentation under /usr/share/doc/muParser-devel-1.27/html. Lots of rpmlint warnings: W: muParser wrong-file-end-of-line-encoding /usr/share/doc/muParser-1.27/License.txt And many others like it; these should be passed through tr or sed or dos2unix in to clean them up. E: muParser library-without-ldconfig-postin /usr/lib64/libmuparser.so.0.0.0 You need %post -p /sbin/ldconfig -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review