https://bugzilla.redhat.com/show_bug.cgi?id=1200955 --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review: + mock build is successful for f23 + rpmlint output on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + License "BSD" is valid and included in LICENSE file. + rest looks following packaging guidelines Suggestions: 1) some cosmetic change in %description is required, change **wrapt** to just wrapt 2) We have now %license macro to use to mark license files. So, you should use it as %license LICENSE 3) You can add README as %doc files. 4) I will suggest to use Source URL as Source0: https://github.com/GrahamDumpleton/%{name}/archive/%{version}.tar.gz The advantage of using github tarball instead of pypi is that we get the documentation files. Now when you change the tarball to github, you need to add subpackage -doc that will install documentation files. Then in %install you should add pushd docs sphinx-build -b html -d build/doctrees . build/html popd 5) bump the release tag, add what changes you did in changelog. Submit a new srpm and spec file links. You may also want to contact upstream to check if wrapt library is python3 compatible or not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review