[Bug 1200768] Review Request: takari-archiver - Takari Archiver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1200768



--- Comment #3 from Alec Leamas <leamas.alec@xxxxxxxxx> ---
Alexander: thanks for changing my bad habits.

Mikolaj: I see basically three issues with this package.

The first is licensing. I cannot find any sign of a EPL or other license in any
README, pom.xml or source files (besides in FileMode.java, below). Furthermore,
you download a license file separate from upstream which normally not is OK. 

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

Please provide more info on what grounds you are applying the EPL license to
this software, possibly after contacting upstream.

The other is that the jar files are not removed in %prep:
http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software

The third is that the BSD licensed file FileMode.java seems to be a bundled
copy of
http://git.eclipse.org/c/jgit/jgit.git/diff/org.eclipse.jgit/src/org/eclipse/jgit/lib/FileMode.java.
This is just a single file, but I still think  you need an FPC exemption for
it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]