https://bugzilla.redhat.com/show_bug.cgi?id=1199693 --- Comment #8 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> --- > There's also a warning for no-documentation on the *-devel package. The story about warnings and errors is really just that rpmlint (and a few other tools) _try_ to be helpful by pointing out things which may be "bad". It is not always MUST-FIX error condition, and in some cases rpmlint is mistaken. Also see: https://fedoraproject.org/wiki/Common_Rpmlint_issues#no-documentation ( from https://fedoraproject.org/wiki/Category:Package_Maintainers ) There are doc files in the tarball, which you could include. Especially: https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > %clean > %if 0%{?rhel} < 6 > %{__rm} -rf %{buildroot} > %endif You can wrap the entire %clean section in the conditionals, since if you don't need it you don't need to include an empty section. %if 0%{?rhel} < 6 %clean %{__rm} -rf %{buildroot} %endif > Name: pcp-pmda-cpp > Group: Development/Libraries The group for base runtime libraries has been "System Environment/Libraries" for many years. The group "Development/Libraries" is for the separate -devel buildtime packages. > %description devel > PMDA++ is a header-only library https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Header_Only_Libraries > %files examples > %{_bindir}/pmda* > %{_datadir}/doc/pcp-cpp/examples/ Directory %{_datadir}/doc/pcp-cpp is not included, and no other package provides it yet either (repoquery --whatprovides /usr/share/doc/pcp-cpp). This needs to be examined. https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories > unit test coverage If the tests are suitable for a %check section, one should be added to the spec file. [Some people disagree because they would like tests to be run much more often than at rpmbuild-time, but %check sections can be helpful if they reveal incompatibilities in a changed build environment.] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review