[Bug 1200769] Review Request: takari-incrementalbuild - Takari Incremental Build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1200769



--- Comment #4 from Mikolaj Izdebski <mizdebsk@xxxxxxxxxx> ---
(In reply to gil cattaneo from comment #2)
> Issues:
> 
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/licenses, /usr/share
>      /maven-metadata, /usr/share/java/takari-incrementalbuild

Not an issue:
/usr/share/licenses is owned by filesystem
/usr/share/maven-metadata is owned by javapackages-tools
/usr/share/java/takari-incrementalbuild is owned by the package itself

> - Bundled jar/class files should be removed before build
>   Note: Jar files in source (see attachment)
>   Please, remove
> io.takari.incrementalbuild-io.takari.incrementalbuild-0.10.0/
> incrementalbuild/src/test/projects/dummy/dummy-1.0.jar

This is not bundled software. This is test resource in its preferable form for
editing, so it qualifies as source code IMHO.

> [!]: If the source package does not include license text(s) as a separate
> file
>      from upstream, the packager SHOULD query upstream to include it.
> [!]: Package does not include license text files separate from upstream.

Upstream deliberately doesn't include license text, but we (downstream) must
convey license text in order to comply with licensing terms. No issue here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]