[Bug 1194254] Review Request: libOnix - A text based "graphics" library.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1194254



--- Comment #2 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
A strange one so far. :-/


> %files
> %doc /usr/share/doc/libonix/README.md
> %{_libdir}/libonix.so

There is just the lib, no API yet!


> rpm-fedora.spec

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Spec_file_name

Even if it only says "should" there, be nice and adhere to such guidelines.


> Source0:	libOnix-%{version}-src.zip

https://fedoraproject.org/wiki/Packaging:SourceURL


> License:	GPLv2

Nothing at all in the source tarballs refers to the licensing.


> %build
> cmake .

http://fedoraproject.org/wiki/Packaging:Cmake


> $ rpm -qp --provides libOnix-1.0.0-1.fc21.x86_64.rpm|grep ^lib
> libOnix = 1.0.0-1.fc21
> libOnix(x86-64) = 1.0.0-1.fc21
> libonix.so()(64bit)

An unversioned SONAME. If anything used this lib already, the automatic
dependency would be very weak.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]