https://bugzilla.redhat.com/show_bug.cgi?id=1200384 Richard W.M. Jones <rjones@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rjones@xxxxxxxxxx --- Comment #1 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- There seems to be a certain amount of copy and paste in the spec file which is not necessary as far as I can see. These entire sections seem to be unnecessary and should be deleted: # Prevent RPM from stripping the binaries & debuginfo. # # NB: Only required because this package uses the obsolete -custom # parameter and builds a bytecode 'ocamlrpcgen'. I tried to fix the # build to make a native code 'ocamlrpcgen' but the build system got # the better of me. %global debug_package %{nil} %global __strip /bin/true #%global __ocaml_requires_opts -i Asttypes -i Outcometree -i Parsetree %global __ocaml_requires_opts -c -f '%{buildroot}%{_bindir}/ocamlrun %{buildroot}%{_bindir}/ocamlobjinfo' %global __ocaml_provides_opts -f '%{buildroot}%{_bindir}/ocamlrun %{buildroot}%{_bindir}/ocamlobjinfo' I also think the commented-out lines in the %files sections should be deleted if they are not needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review