https://bugzilla.redhat.com/show_bug.cgi?id=1200064 --- Comment #1 from Richard Shaw <hobbes1069@xxxxxxxxx> --- Ok, some drive by comments first: 1. BuildRoot, %clean, and deffattr (in %files) shouldn't be needed unless you plan to support much older versions of Fedora or EPEL 5, correct? 2. %global upstream_name python-ly is set but never used and is the same as the package name (Is this left over from another package where upstream wasn't correct for the package naming guidelines?) 3. CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build I don't think you needs the CFLAGS since it's a noarch pure python package. 4. rm -rf %{buildroot} in %install I don't think this is needed except in rare circumstances and the guidelines don't show it being used so I think it's safe to remove. 5. %doc ChangeLog README.rst doc/ The doc/ directory also includes a Makefile and config file for building the documentation so we don't want to include those but I also took a look at the RST files and it looks like the documentation needs to be generated. It's not usable as is. This would require an additional BuildRequires of sphinx and then a "make html" in the doc dir. These should probably go in a -doc subpackage but I'm open to suggestion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review