https://bugzilla.redhat.com/show_bug.cgi?id=1196290 --- Comment #1 from Piotr Popieluch <piotr1212@xxxxxxxxx> --- some comments: - please remove the scl macros, they are not needed for fedora - remove group: this is only needed if you intend building for epel5 - remove BuildRoot: this is only needed if you intend building for epel5 - remove defattr, this is not needed anymore - add ExclusiveArch: %{nodejs_arches} noarch for fedora > 19 https://fedoraproject.org/wiki/Packaging:Node.js#ExclusiveArch - move license from %doc to %license https://fedoraproject.org/wiki/Packaging:LicensingGuidelines - add %check sections with tests, see package.json how to call the tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review