[Bug 1193923] Review Request: mbedtls - polarssl package renaming process

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1193923



--- Comment #2 from Morten Stevens <mstevens@xxxxxxxxxxxxxxx> ---
Hi,

Here is the latest mbedtls.spec file:

https://mstevens.fedorapeople.org/mbedtls/mbedtls.spec
https://mstevens.fedorapeople.org/mbedtls/mbedtls-1.3.10-1.fc23.src.rpm

(In reply to Christopher Meng from comment #1)
> 1. URL: https://tls.mbed.org/

fixed

> 2. Conflicts: polarssl
> 
> I think this is incorrect, as from the rename, OBsoletes tag should be used:
> 
> Obsoletes: polarssl < %{version}-%{release}

fixed

> 3. %cmake -D CMAKE_BUILD_TYPE:String="Release" .
> make %{?_smp_mflags} all apidoc
> 
> %cmake -D CMAKE_BUILD_TYPE:String="Release" -D
> USE_SHARED_MBEDTLS_LIBRARY:BOOL=1 .
> make %{?_smp_mflags} all apidoc
> 
> Duplicate?

Yes, fixed.

> 4. %doc LICENSE ChangeLog
> 
> Use %license macro.

fixed

> 5. No tests available for %check?

There is a check available. I've added the check, but the check is currently
disabled due a bug.

# check temporarily disabled due a bug
# %check
# LD_LIBRARY_PATH=$PWD/library ctest --output-on-failure -V

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]