[Bug 1198312] Review Request: xpra - screen for X

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1198312



--- Comment #12 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> ---
(In reply to Jonathan Underwood from comment #7)
> (In reply to T.C. Hollingsworth from comment #2)
> > > * rencode              : Y
> > > * server               : Y
> > > * shadow               : Y
> > > * sound                : Y
> > > * strict               : Y
> > > * swscale_static       : N
> > > * verbose              : N
> > > * vpx                  : N
> > 
> > Is it still necessary to disable this?
> > 
> > libswscale isn't strictly required these days:
> > https://www.xpra.org/trac/wiki/CSC
> 
> I am a bit confused here as, as I think you're conflating two issues - vpx,
> and CSC, but perhaps I misunderstand.

They're related issues.  All the video codecs require a CSC to perform
pre-conversion except in certain limited circumstances.  In the earlier version
of the code, there weren't any such limited circumstances and libswscale from
ffmpeg was the only CSC.  That's why vpx was previously disabled.

See the comments from Antoine, an upstream developer, in the old bug for more
details on all this.  Note also that he said improvements were on the way, and
they came.  Now that there are multiple CSC implementations and at least one
that works on Fedora, vpx and other future libre codecs should work fine.

> Anyway, regarding CSC, upstream defaults are:
> 
>   --with-csc_opencl       or   --without-csc_opencl         (default: False)
>   --with-csc_cython       or   --without-csc_cython         (default: True)
> 
> so, --without-csc_opencl and --with-csc_cython. Are you saying you'd like to
> see the package use --with-csc_opencl and --without-csc_cython instead? 

No, you can build more than one of these.  The wiki oddly says that opencl is
enabled by default these days, but I guess the code is what counts so this can
be skipped for now.

=====

It sounds like all the issues I've found so far have been addressed.  Let me
put it through a few more paces and see if we can't get this approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]