https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Gerard Ryan <gerard@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Gerard Ryan <gerard@xxxxxxx> --- (In reply to Piotr Popieluch from comment #3) > Hi Gerard, > > Thank you for pointing me to the Github source URL guidelines, it never > occurred to me that those might exist.. I probably have a dozen of packages > using this incorrectly. I will check all my packages next weekend. > Yes, it's hard to remember all of the rules all the time...it's a good thing we force ourselves to get our packages reviewed! :) I guess this particular one is because the tags aren't necessarily immutable, but the commit hashes are. > I've updated the spec and srpm without a version bump. > > Thank you for reviewing! Thank you for packaging! It looks good to me now, so I'll approve it. For any innocent bystanders, here's the diff of the spec file between the two versions: --- srpm/nodejs-onetime.spec 2015-03-01 17:56:35.285000000 +0000 +++ nodejs-onetime.spec 2015-03-04 19:55:43.000000000 +0000 @@ -3,14 +3,15 @@ %global enable_tests 1 %global srcname onetime +%global commit a4aa1ce5291cc5f32ecb8f4b0a918b12cb47ea5e Name: nodejs-%{srcname} Version: 1.0.0 Release: 1%{?dist} Summary: Only call a function once License: MIT -URL: https://github.com/sindresorhus/onetime -Source0: https://github.com/sindresorhus/%{srcname}/archive/v%{version}/%{srcname}-%{version}.tar.gz +URL: https://github.com/sindresorhus/%{srcname} +Source0: https://github.com/sindresorhus/%{srcname}/archive/%{commit}/%{srcname}-%{commit}.tar.gz BuildArch: noarch ExclusiveArch: %{nodejs_arches} noarch @@ -28,7 +29,7 @@ %prep -%setup -q -n %{srcname}-%{version} +%setup -q -n %{srcname}-%{commit} rm -rf node_modules/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review