https://bugzilla.redhat.com/show_bug.cgi?id=1198342 --- Comment #4 from Matthew Miller <mattdm@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #2) > 1. %check section is needed for > make check Sure, will add. > 2. Disable silent build by passing --disable-silent-rules to %configure, > then you will see trouble 4. Hmmm; maybe that should be standard? Good catch. > 3. Consider packaging octave binding(*optional*, as I don't find it useful > so far, might not for others I think). Is this bringing in baggage if you rebuild with octave-devel as a build-requires (or out of mock on a system with it installed)? I guess I could subpackage, but as it's not mentioned in the docs (is it? did I miss something?) I'm inclined to just leave it out. > 4. CFLAGS are being overriden by march=native(aarch64 doesn't support it) > and even others, this is not not good, please patch. Rüdiger Meier, I'll wait as suggested... presumably fixed? > 5. These program names are too common, please consider passing > --program-prefix='dateutils.', as it even conflicts with RHEL dapl-utils > package(It's not in Fedora I checked). I think that'd make them significantly less handy, and unless there are really strong feelings here, I think I'd prefer to leave as-is, or as a worst case change the initial 'd' to expanded 'date' — dateadd, dateconv, etc. (But that also seems like a big deviation from upstream!) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review