Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rott - Rise of the Triad https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239785 ------- Additional Comments From faucamp@xxxxxxxxxx 2007-05-16 09:15 EST ------- (In reply to comment #2) Ok, it does seem to be a timeout issue combined with my questionable network connection. Increasing the timeout threshold makes things a bit better, but it might be a good idea to have some form of "download resume" option (like wget's -c option) - maybe urllib.urlretrieve() can be replaced with a call to wget? But this is a discussion for another bugzilla, I think. :-) As far as reviewing the package goes, a few points: * The program crashes on startup on my machine (FC6/i386 dual core) if the SRPM is rebuilt as-is; will attach the output (backtrace) shortly. After removing $RPM_OPT_FLAGS from the EXTRAFLAGS parameter to make, it builds and runs fine. my RPM_OPT_FLAGS: -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables * It looks like you are missing some useful %doc entries: rott/13todo.txt (highlights some bugs/missing features in port) rott/cmdline.txt (provides command line options) rott/hacker.txt (useful for creating custom maps) rott/wad.txt (useful for creating custom content) * I have my doubts about the "rott-registered" package: it doesn't feel "polished", in that it is a standalone installable "game package", yet it does not create a suitable menu entry, or provide some assistance with actually getting the game to work (the way rott-shareware does). Also, I'm not too sure about Fedora's legal view on this (rott-registered) - since you need proprietary, non-freely downloadable content for it to work. This would be the case with Quake 3 mentioned in comment #3 above, as well. My personal feeling on rott-registered is to either polish it up to provide the same level of "user friendliness" as rott-shareware (and maybe make it Conflict with rott-shareware if needed), or drop it. (In reply to comment #3) http://fedoraproject.org/wiki/Extras/SteeringCommittee/Meeting-20070510 As I said above though, I'm not sure about the "registered" stuff, though. Maybe provide a "codec buddy"-like popup message with 3D Realms's "buy rott" URL? (they actually still sell it, believe it or not) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review