https://bugzilla.redhat.com/show_bug.cgi?id=1198312 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |tchollingsworth@xxxxxxxxx Flags| |fedora-review? | |needinfo?(jonathan.underwoo | |d@xxxxxxxxx) --- Comment #2 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- Thanks, I'm happy for someone with more time to take this over. Sorry I missed your earlier ping. I'll review instead! :-) ===== Some issues: ---- > Requires: python-webm >= 0.2.2-3 AFAICT, this isn't needed anymore. Also, you're not building webp support, see below. ---- This is what the buildsystem reports as enabled/disabled when I built it here. Some prohibited items are still built if the dependencies are around, and there appear to be some things that could possibly be enabled. > * PIC : Y > * Xdummy : Auto > * Xdummy_wrapper : Auto > * argb : Y > * avcodec2_static : N > * avcodec_static : N > * bencode : Y > * bundle_tests : N > * client : Y > * clipboard : Y > * csc_cython : Y > * csc_opencl : N This should be enabled by default, but you are missing the necessary BuildRequires/Requires. https://www.xpra.org/trac/wiki/CSC/OpenCL > * csc_swscale : N > * cymaths : Y > * cython_bencode : Y > * cyxor : Y > * debug : N > * dec_avcodec : N > * dec_avcodec2 : Y This is a prohibited item and should be disabled. > * enc_x264 : N > * enc_x265 : N > * gtk2 : Y > * gtk3 : N I guess this is disabled because it is unstable, but please keep an eye out for this to change in future releases. > * gtk_x11 : Y > * html5 : Y > * memoryview : N > * nvenc : N > * opengl : Y > * qt4 : N Same here. > * rencode : Y > * server : Y > * shadow : Y > * sound : Y > * strict : Y > * swscale_static : N > * verbose : N > * vpx : N Is it still necessary to disable this? libswscale isn't strictly required these days: https://www.xpra.org/trac/wiki/CSC > * vpx_static : N > * warn : Y > * webp : N Why is this disabled? If the upstream defaults have changed, it might still be nice to enable this, given we'll lack support for many other codecs in Fedora. (OTOH if you get vpx working this could be left off.) > * webp_static : N > * x11 : Y > * x264_static : N > * x265_static : N ---- Some prohibited content is installed: > drwxr-xr-x /usr/lib64/python2.7/site-packages/xpra/codecs/dec_avcodec2 > -rw-r--r-- /usr/lib64/python2.7/site-packages/xpra/codecs/dec_avcodec2/__init__.py > -rw-r--r-- /usr/lib64/python2.7/site-packages/xpra/codecs/dec_avcodec2/__init__.pyc > -rw-r--r-- /usr/lib64/python2.7/site-packages/xpra/codecs/dec_avcodec2/__init__.pyo > -rwxr-xr-x /usr/lib64/python2.7/site-packages/xpra/codecs/dec_avcodec2/decoder.so ffmpeg, see above > -rw-r--r-- /usr/share/xpra/www/include/web-socket-js/WebSocketMain.swf SWF files are prebuilt binary programs, please remove them from the package: https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries This code prefers to use native WebSocket functionality so you can safely delete the Flash file and the HTML5 client will still work fine in modern browsers. ---- Bundled JavaScript libraries: > -rw-r--r-- /usr/share/xpra/www/include/jquery.min.js Please add Requires: js-jquery and add `ln -sf ../../javascript/jquery/2/jquery.min.js %{buildroot}%{_datadir}/xpra/www/include/jquery.min.js` to %install to avoid bundling. > -rw-r--r-- /usr/share/xpra/www/include/jqueryui.min.js Not yet packaged. Please add `Provides: bundled(js-jquery-ui) = 1.10.4` for tracking purposes. > drwxr-xr-x /usr/share/xpra/www/include/web-socket-js Not yet packaged. Please add `Provides: bundled(js-web-socket-js)` for tracking purposes. ---- Only one rpmlint warning of interest: > xpra.x86_64: E: script-without-shebang /usr/share/xpra/www/include/web-socket-js/web_socket.js Please make this file nonexecutable. ==== I think that's enough for now. This package NEEDS WORK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review