[Bug 1197520] Review Request: xfce4-pulseaudio-plugin - Pulseaudio panel plugin for Xfce Panel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1197520



--- Comment #3 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
(In reply to Sandro Mani from comment #2)
> Looks good! I'll approve right away, there are only a handful of issues to
> consider before importing:
> 
> xfce4-pulseaudio-plugin.x86_64: E: incorrect-fsf-address
> /usr/share/licenses/xfce4-pulseaudio-plugin/COPYING
> xfce4-pulseaudio-plugin.src: W: strange-permission
> xfce4-pulseaudio-plugin.spec 0600L
> => These should be fixed, the COPYING issue reported upstream
> 

Reported upstream. https://bugzilla.xfce.org/show_bug.cgi?id=11638

> 
> make install DESTDIR=%{buildroot} could be replaced by %make_install
> 
> Also, have a look at the rpmlint output on the installed packages.
> 
> 


I will change this before I check-in and build the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]