https://bugzilla.redhat.com/show_bug.cgi?id=1195279 --- Comment #20 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- - Why BR:pykickstart R:pykickstart in F23? - Can you add %check back? - Why the extra directory level in %{_rpmconfigdir}/macros.d/macros.preupgrade-assistant/macros.preupgrade-assistant? I don't see other packages doing this. - %preupgrade_build is defined to the old name /usr/bin/create_group_xml. - preupgrade-assistant.rpm has an empty /usr/share/doc/preupgrade directory and README files are in /usr/share/preupgrade. - I installed the rpm on F21. /usr/bin/preupg fails with: Traceback (most recent call last): File "/usr/bin/preupg", line 8, in <module> from preup.application import Application File "/usr/lib/python2.7/site-packages/preup/application.py", line 18, in <module> from preuputils.compose import XCCDFCompose ImportError: No module named preuputils.compose Installing also -devel subpackage fixes that. Maybe you should merge -devel back into the main package. They are both really tiny, so the split is probably not worth the trouble. - Looking at the first message: The Preupgrade Assistant is a diagnostics tool and does not perform the actual upgrade. Make sure you back up your system and all of your data now, before using the Upgrade Tool to avoid potential data loss. Do you want to continue? y/n If it is only a diagnostic tool, why is it unsafe to run? Also, why does it require root privileges? Isn't the RPM database public? - In the man page: "All common log files are stored in /var/cache/preupgrade/common". Isn't /var/log/preupgrade used? - This package seems useless without preupgrade-assistant-contents. Is this available somewhere? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review