https://bugzilla.redhat.com/show_bug.cgi?id=1197898 --- Comment #5 from David King <amigadave@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find COPYING in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text This is bogus, as it predates %license. Owning /usr/share/icons/HighContrast (or a Requires of gnome-themes-standard) should fix the directory ownsership problem. As the package is a split, you should add some appropriate Conflicts: https://fedoraproject.org/wiki/Packaging:Conflicts ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/1197898-dconf- editor/licensecheck.txt [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/HighContrast/22x22, /usr/share/icons/HighContrast/256x256, /usr/share/icons/HighContrast, /usr/share/icons/HighContrast/32x32, /usr/share/icons/HighContrast/24x24/apps, /usr/share/icons/HighContrast/16x16/apps, /usr/share/icons/HighContrast/32x32/apps, /usr/share/icons/HighContrast/48x48, /usr/share/icons/HighContrast/22x22/apps, /usr/share/icons/HighContrast/16x16, /usr/share/icons/HighContrast/48x48/apps, /usr/share/icons/HighContrast/256x256/apps, /usr/share/icons/HighContrast/24x24 Mentioned above. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: glib-compile-schemas is run in %postun and %posttrans if package has *.gschema.xml files. Note: gschema file(s) in dconf-editor [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in dconf-editor [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Mentioned at the beginning of the review (missing Conflicts). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.2.7 starting (python version = 3.4.2)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Mock Version: 1.2.7 INFO: Mock Version: 1.2.7 Finish: chroot init INFO: installing package(s): /home/david/checkout/rpms/1197898-dconf-editor/results/dconf-editor-3.15.91-2.fc22.x86_64.rpm ERROR: Command failed. See logs for output. # /usr/bin/yum --installroot /var/lib/mock/fedora-22-x86_64/root/ --releasever 22 install /home/david/checkout/rpms/1197898-dconf-editor/results/dconf-editor-3.15.91-2.fc22.x86_64.rpm --setopt=tsflags=nocontexts Mentioned above. Rpmlint ------- Checking: dconf-editor-3.15.91-2.fc22.x86_64.rpm dconf-editor-3.15.91-2.fc22.src.rpm dconf-editor.x86_64: W: no-documentation dconf-editor.x86_64: W: no-manual-page-for-binary dconf-editor dconf-editor.x86_64: E: invalid-appdata-file /usr/share/appdata/ca.desrt.dconf-editor.appdata.xml 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Fixed with the patch in the spec file. Requires -------- dconf-editor (rpmlib, GLIBC filtered): /bin/sh libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libdconf.so.1()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) Provides -------- dconf-editor: appdata() appdata(ca.desrt.dconf-editor.appdata.xml) application() application(ca.desrt.dconf-editor.desktop) dconf-editor dconf-editor(x86-64) Source checksums ---------------- https://download.gnome.org/sources/dconf-editor/3.15/dconf-editor-3.15.91.tar.xz : CHECKSUM(SHA256) this package : 67d4bb73500e185e33f19d71662325da8c625080d497d71fd11760cfbe758138 CHECKSUM(SHA256) upstream package : 67d4bb73500e185e33f19d71662325da8c625080d497d71fd11760cfbe758138 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1197898 Buildroot used: fedora-22-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review