Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Net-Ping - Execute ping https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239906 ------- Additional Comments From Fedora@xxxxxxxxxxxxxxxxx 2007-05-16 06:59 EST ------- Thanks for the review. Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Ping.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-Ping-2.4.1-2.fc8.src.rpm %changelog * Wed May 16 2007 Remi Collet <Fedora@xxxxxxxxxxxxxxxxx> 2.4.1-2 - From review, correct typo. - add Requires: /bin/ping - add simple test in %%check I requires /bin/ping rather than iputils after asking #fedora-devel. I don't really prefer one solution to another. It will work even if ping gets moved to another package. When packaging pear stuff, most often, tests must be run after installing the package (doesn't run in Buildroot, even with R changed to BR). Running tests after installation allow to be more complete (need configuration change, databse...), ex running /usr/share/doc/php-pear-Net-Ping-2.4.1/examples/example.php. But, of course, i agree to include test when exists and works. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review