[Bug 1197499] Review Request: java-wakeonline - Wake On Lan client and java library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1197499



--- Comment #26 from Alec Leamas <leamas.alec@xxxxxxxxx> ---
(In reply to gil cattaneo from comment #25)

> java-wakeonlan.noarch: E: incorrect-fsf-address
> /usr/share/licenses/java-wakeonlan/COPYING

I have informed upstream about this (comment #1)

> Suggestion:
> use also https://bugzilla.redhat.com/attachment.cgi?id=996898
> CMDResources_it.properties

Of course, sorry I missed that. It was certainly not on purpose. Fixed.

> fix icon name 
> is not %{_datadir}/icons/hicolor/64x64/apps/%{name}-inspector.png but
> %{_datadir}/icons/hicolor/64x64/apps/%{name}.png

Fixed

> if possible repackage the source archive and remove
> ./wakeonlan-1.0.0/lib/jsap.jar

Certainly possible, but is it a good idea? The GL [1] requires us to remove the
jars in %prep, but there is nothing about repacking the source in such cases.
And as one of the fedora-review maintainers I can confirm that the message 
just is a heads up that there is jars to deal with. 

Still on release 3, new changelog entry , same links:

spec: https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan.spec
srpm:
https://leamas.fedorapeople.org/harctoolbox/java-wakeonlan-1.0.0-3.fc21.src.rpm

[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]