https://bugzilla.redhat.com/show_bug.cgi?id=1045676 --- Comment #10 from František Dvořák <valtri@xxxxxxxxxx> --- Some more details (I'm sorry not noticing before): 1) for the license file it better to use %license tag, something like: %license COPYING %doc sunwait.html 2) timestamps should be preserved (http://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps), so you can use: cp -p %{SOURCE1} sunwait.html 3) the warning "incompatible implicit declaration" may be sometimes quite dangerous (in case there is returned pointer implicitly retyped into int) Here it is OK, the strstr() is checked only on non-zero return value. You can consider patching main.c and include <string.h> there (but it isn't needed). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review