[Bug 1195279] Review Request: preupgrade-assistant - Preupgrade assistant a tool for assess system before an upgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1195279

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx



--- Comment #9 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Created attachment 996036
  --> https://bugzilla.redhat.com/attachment.cgi?id=996036&action=edit
fedora-review output

(In reply to Petr Hracek from comment #8)
> > > Regarding configparser. All is working properly.
> > > configparser.py provides class ConfigParser in F22 and in F23 too.
> > > This was not changed.
> > The class name did not change. But the module name did.
> 
> Well, I have checked the class name and module name configparser.py and both
> are identical. F22 and F23.
It changed between Python 2 and 3. In comment #c5 there's a code snippet to
make the code compatible with both versions.

OK, I see you removed %check. This is *not* the way to go. If the tests find a
problem, fix the problem, don't remove the tests!

We are going in circles. Let's go back to the beginning, and start with the
basic questions:

- what python version is preupgrade-assistant supposed to run? Is it going to
be packaged for F21? Is the answer the same for both F23 and F22 and F21? 

Some data points:
- in F22 pykickstart is at 1.99.66 and does *not* provide a python 3 version
- in F23 pykickstart is at 2.0 and does provide python3-kickstart
- the version in F21 is even older and does Python 2 only
- the code in ./preuputils/oscap_group_xml.py is atm Python2 only

> Spec URL: https://phracek.fedorapeople.org/preupgrade-assistant.spec
> SRPM URL:
> https://phracek.fedorapeople.org/preupgrade-assistant-0.11.7-1.fc21.src.rpm
> 
> Would it be possible to execute fedora-review and paste result?
> In F21 I have problems with fedora-review.
Attached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]