Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Danga-Socket - Event loop and event-driven async socket base class https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239933 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-15 17:32 EST ------- My only suggestion is that you include the examples directory as %doc. I don't think this is a blocker, though. * source files match upstream: 919be5206f5e9dbff4a825a5bea3ed9f223629c2e969360a6228a929c838c7f5 Danga-Socket-1.57.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Danga::Socket) = 1.57 perl(Danga::Socket::Timer) perl-Danga-Socket = 1.57-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Errno) perl(POSIX) perl(Socket) perl(Sys::Syscall) perl(Time::HiRes) perl(bytes) perl(constant) perl(fields) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=4, Tests=59, 8 wallclock secs ( 0.22 cusr + 0.06 csys = 0.28 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review