https://bugzilla.redhat.com/show_bug.cgi?id=1195375 Orion Poplawski <orion@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orion@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxxxxxxx --- Comment #1 from Orion Poplawski <orion@xxxxxxxxxxxxx> --- Thanks for putting this together. First notes: You should make use of the requires/provides filtering mechanism described here: http://fedoraproject.org/wiki/EPEL:Packaging_Autoprovides_and_Requires_Filtering Drop %defattr() No need for %clean or rm -rf ${RPM_BUILD_ROOT}, or BuildRoot. Otherwise looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review