https://bugzilla.redhat.com/show_bug.cgi?id=1188524 --- Comment #3 from Piotr Popieluch <piotr1212@xxxxxxxxx> --- Could you please remove the second %check section. I have enabled the tests and they fail: date-tokens + dt ✓ should return the tokens object of functions ✓ should return the tokens object of functions, if function called, should return current time ✓ should return the tokens object of functions, if function called without param, should use param in dt() ✓ should return the tokens object of functions, if function called with param, should use param ✓ should return the tokens object of functions with tokens named with the prefix ✓ should return the tokens object of functions with tokens named with the prefix and current time + eval ✓ should return the tokens object of strings of eval'd dates ✓ should return the tokens object of strings and should return current time 1) should return the tokens object of strings should use param in eval() ✓ should return the tokens object of strings with tokens named with the prefix ✓ should return the tokens object of strings with tokens named with the prefix and return current 10 passing (14ms) 1 failing 1) date-tokens + eval should return the tokens object of strings should use param in eval(): AssertionError: false == true at Context.<anonymous> (/home/piotr/rpmbuild/BUILD/node-date-tokens-0.0.2/test/date-tokens.test.js:86:13) at callFn (/usr/lib/node_modules/mocha/lib/runnable.js:223:21) at Test.Runnable.run (/usr/lib/node_modules/mocha/lib/runnable.js:216:7) at Runner.runTest (/usr/lib/node_modules/mocha/lib/runner.js:374:10) at /usr/lib/node_modules/mocha/lib/runner.js:452:12 at next (/usr/lib/node_modules/mocha/lib/runner.js:299:14) at /usr/lib/node_modules/mocha/lib/runner.js:309:7 at next (/usr/lib/node_modules/mocha/lib/runner.js:247:23) at Object._onImmediate (/usr/lib/node_modules/mocha/lib/runner.js:276:5) at processImmediate [as _immediateCallback] (timers.js:345:15) Could you check why they fail? Tests are a good indicator if the library actually works as intended. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review