Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Text-TabularDisplay - Display text in formatted table output https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=240174 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-05-15 16:56 EST ------- I only have one question: The tests seem to need perl(Test) while you have a build-time dependency on perl(Test::More). At this point I'm not sure what the plan is, but as is I'd wager that you have the wrong BuildRequire there. Since we chatted about this on IRC, I'll go ahead and approve this and you can check in with the quick fix. * source files match upstream: 87856a053cccba8059c194da15300271ea800ab37c44e01f34612be4da962317 Text-TabularDisplay-1.22.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream (GPL statement is in the code itself) * latest version is being packaged. ? BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: perl(Text::TabularDisplay) = 1.22 perl-Text-TabularDisplay = 1.22-1.fc7 = perl(:MODULE_COMPAT_5.8.8) perl(integer) perl(strict) perl(vars) * %check is present and all tests pass: All tests successful. Files=15, Tests=83, 0 wallclock secs ( 0.20 cusr + 0.14 csys = 0.34 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review