https://bugzilla.redhat.com/show_bug.cgi?id=1195279 --- Comment #5 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Petr Hracek from comment #4) > Today finally my mock is running. > > But python3 does not exist rawhide yet. > http://koji.fedoraproject.org/koji/packageinfo?packageID=9781 > And therefore ConfigParser is not available yet:( When I look at the list, I see three F23 builds right at the top. I'm not sure why do you think that there are no rawhide builds. > ConfigParser class is defined in configparser.py file, though. > ConfigParser (configparser.py) is part of subpackage python3-libs. Yeah, it got renamed. You need to either rename it too, or if you're providing Py2 compat, use something like: try: import configparser except ImportError: import ConfigParser as configparser > Thanks for good idea with renaming binaries. It really makes sense. > I am going to do that. Cool, thanks. > I tried to build package in Copr, but F22 branch does not exist yet. You might need to update you mock package first. It carries the buildroot definitions. F22 and F23 build roots have been working for the last few weeks or so. > I have updated SPEC file so that in F22 it uses python2. But Since F23 is > uses python3. This makes things much more complicated for no good reason. The spec file is much more complicated, and it'll also be confusing for users. I'd strongly advise against that. Although not strictly required, the intent of %license is to be used with bare filename, so that the file is installed in /usr/share/licenses. Please remove LICENSE from %{_pkgdocdir} and add in %files: %license LICENSE fedora-review says: - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/tmp/1195279-preupgrade- assistant/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL E: explicit-lib-dependency python3-libs Yep, such dependencies are added automatically. W: spurious-executable-perm /usr/share/man/man1/preupg.1.gz E: non-executable-script /usr/lib/python3.4/site-packages/preuputils/postupgrade.py 0644L /usr/bin/python2 preupgrade-assistant.src:96: W: macro-in-comment %{__python2} preupgrade-assistant.src:97: W: macro-in-comment %else preupgrade-assistant.src:98: W: macro-in-comment %{__python3} preupgrade-assistant.src:99: W: macro-in-comment %endif I hope you can reverse the Python2 / 3 split. I'll hold on actually testing the package and further review until you make the decision. Testing both versions is twice as much work :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review