[Bug 1196347] Review Request: f22-backgrounds – Fedora 22 default desktop background

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1196347

Jaroslav Reznik <jreznik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jaroslav Reznik <jreznik@xxxxxxxxxx> ---
(In reply to Martin Sourada from comment #0)
> +++ This bug was initially created as a clone of Bug #1133217 +++
> Additional info:
> Package structurally same as previous default themes, supplemental
> wallpapers will come later (I already have the images, but they don't need
> to be in alpha).

Confirmed the package structure is as in the previous version (except
supplemental wallpapers that are still undergoing collection). All strings are
correctly updated to F22.

Package builds - http://koji.fedoraproject.org/koji/taskinfo?taskID=9080407 -
and installs correctly.

> Rpmlint output comment: 
> missing Docs OK, as the affected packages are dependant on the
> f22-backgrounds-base (sub)package that has the Docs, same with dangling
> symlinks.

No new rpmlint issues found except docs and symlinks mentioned above.

Just one thing I spotted for KDE sub-package. 

%files kde
%{_kde4_datadir}/wallpapers/%{Bg_Name}/

KDE 4 is going to be replaced with Plasma 5 in Fedora 22 but the wallpapers
location is still the same. I confirmed it with KDE SIG and tested - it works
as expected. So it's not a blocker for review but would be nice to sync with
KDE SIG (KDE 4 macros are not going away in the near future but...)

As there are minimal changes in SPEC file (just version update to match current
release, no extras yet) and all know rpm issues are known (and correct as
stated above), package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]