[Bug 1195279] Review Request: preupgrade-assistant - Preupgrade assistant a tool for assess system before an upgrade

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1195279



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Use %license for LICENSE. See
https://fedorahosted.org/fpc/ticket/411#comment:11 for a fallback.

Now it fails with:
File
"/builddir/build/BUILD/preupgrade-assistant-0.11.5/preuputils/oscap_group_xml.py",
line 8, in <module>
    import ConfigParser
ImportError: No module named 'ConfigParser'

There's only configparser afaik.

Then it fails with:
File
"/builddir/build/BUILD/preupgrade-assistant-0.11.5/preuputils/script_utils.py",
line 6, in <module>
    import xml_utils
ImportError: No module named 'xml_utils'

This seems to be an incompatible absolute import.

I have the feeling nobody ever run this code?!

It would be great if you could check if it builds in mock for you.

Spec file mostly looks good. I'm wondering though, before this gets set in
stone: binaries like create_group_xml are rather generic. Maybe you could
rename them to preupg-create-group-xml, preupg-xccdf-compose, etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]