Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nagi - An interpreter for AGI games https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=239812 musuruan@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |musuruan@xxxxxxxxx ------- Additional Comments From musuruan@xxxxxxxxx 2007-05-15 15:15 EST ------- I just had a glance at the spec file. Here it is what I noticed: 1. Do not use dos2unix. Use sed: http://fedoraproject.org/wiki/Packaging/Guidelines#head-41d4336fa1af8d74500eb89d3a22410cccc4117d 2. Release tag is not compliant with guidelines: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-e104844825856d7c45f2f0241586985c0495966b 3. the pwd command in %prep was probably there after some testing and should be removed Andrea. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review