https://bugzilla.redhat.com/show_bug.cgi?id=1195279 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Is python-kickstart a thing? I see only pykickstart here. You can remove the dependencies on ldconfig, they will be added automatically when you use ldconfig in the %post/%postun scriplets. In %description, there's a stray "L". "User can specify only INI file and scripts and other stuff needed by oscap is generated automatically." → something is wrong with this sentence. Requires: %{name} <------ remove this one Requires: %{name} = %{version} Can the package be noarch? I this will not be built for old EPELs, remove Group, BuildRoot, %clean, %defattr. Use %post -p /sbin/ldconfig for %post. It does not require bash invocation. Use %{_docdir} instead of %{_datadir}/doc. Remove 'cp %SOURCE1 .', you copy it from the source location later on anyway. Remove 'mkdir -p -m 755 $RPM_BUILD_ROOT%{_rpmconfigdir}/macros.d' and add -D on the next line. The same for 'install -d -m 755 $RPM_BUILD_ROOT%{_mandir}/man1'. The tests fail for me with: ====================================================================== ERROR: test_opts (tests.test_preup.TestCLI) basic test of several options ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/preupgrade-assistant-0.11.5/tests/test_preup.py", line 111, in test_opts "--contents", "content/FOOBAR6_7", "--cleanup"]) File "/builddir/build/BUILD/preupgrade-assistant-0.11.5/preup/cli.py", line 22, in __init__ self.opts, self.args = self.parser.parse_args(args=args) File "/usr/lib/python2.7/optparse.py", line 1402, in parse_args self.error(str(err)) File "/usr/lib/python2.7/optparse.py", line 1584, in error self.exit(2, "%s: error: %s\n" % (self.get_prog_name(), msg)) File "/usr/lib/python2.7/optparse.py", line 1574, in exit sys.exit(status) SystemExit: 2 Why would anyone use optparse instead of argparse in this day and age is beyond me, but it's not a packaging issue, ... so this is just a side note, not part of the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review