[Bug 1178912] Review Request: cairo-dock-plug-ins - Plug-ins files for Cairo-Dock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1178912



--- Comment #31 from Jan Pokorný <jpokorny@xxxxxxxxxx> ---
...continued:

- I would suggest making c-d-p-i-base -- rather than c-d-p-i directly --
  dependent on c-d-python2 (it would be pulled by installing c-d-p-i
  transitively via c-d-p-i-base anyway and the dependency chain would
  be more transparent, IMHO)


- I am still not too familiar with the file location inter-dependencies
  but it seems to me either of following steps should be made to make
  CDBashApplet.py useful in any way:

  a. patch "self.app_folder = [...]" line in CDBashApplet.py file
     in c-d-python{2,3} packages so as to point to the directory
     containing CDBashApplet.sh from c-d-p-i-dbus (which is already
     required by the "python" packages)

  b. make a symlink under site-packages subdir in c-d-python{2,3}
     packages to CDBashApplet.sh from c-d-p-i-dbus
    (requirement-already-satisfied note applies here as well)

- more out of curiosity, I'd like to verify that

> # Modify CDApplet.h
> sed -i .%{_datadir}/cairo-dock/plug-ins/Dbus/CDApplet.h \
> 	-e '\@def@s|__.*\(DBUS_INTERFACES_VALA_SRC_CDAPPLET_H__\)|__\1|'

part has been added as a matter of "purity" (i.e., suppressing
identifiers accidentally leaking some info about who run "Vala compiler"
(not familiar with that)

- suggested cosmetics in Requires:
  cairo-dock-plug-ins-common -> %{name}-common
  ditto dbus subpackage (+perhaps more)


Otherwise happy about the current state of the package.  Will give it an
install-and-run try, but do not expect any issue there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]