[Bug 1188514] Review Request: nodejs-time -time.h bindings for Node.js

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1188514

Piotr Popieluch <piotr1212@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |piotr1212@xxxxxxxxx



--- Comment #1 from Piotr Popieluch <piotr1212@xxxxxxxxx> ---
some comments:


- this is a native module and needs to be compiled
see:
https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Building_native_modules_with_node-gyp
for instructions on how to build the module


- package fails to install on rawhide:

[root@localhost ~]# dnf install nodejs-time-0.11.0-1.fc23.noarch.rpm
Failed loading plugin: kickstart
Using metadata from Mon Feb 23 20:58:32 2015
Error: nothing provides npm(nan) = 1.1.2 needed by
nodejs-time-0.11.0-1.fc23.noarch

nodejs_fixdep might help with this


- description too long
please rewrap to 80 chars width


- please enable tests
%global enable_tests 1


- %check section occurs twice in spec file
please remove one


- symlink deps missing in %build
or is this not needed?


- %nodejs_symlink_deps --check missing in %check section
please add this

- latest version is 0.11.1 packaged is 0.11.0
please update

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]